Incorrect indexing in NCDISPATCH_initialize()

[ckhroulev]

Looking at the code of NetCDF-C 4.7.2 (commit 108e938) I noticed that NCDISPATCH_initialize() contains the following:

    {
	size_t* c0 = (size_t*)NC_coord_zero;
	size_t* c1 = (size_t*)NC_coord_one;
	ptrdiff_t* s1 = (ptrdiff_t*)NC_stride_one;
        for(i=0;i<NC_MAX_VAR_DIMS;i++) {
	    c0[0] = 0;
	    c1[i] = 1;
	    s1[i] = 1;
	}
    }

I suspect that c0[0] above should be replaced by c0[i]. This code was introduced by #1379.

Please feel free to close this if the code quoted above is correct as it stands.

[WardF]

I believe you are correct, and I am tagging in @DennisHeimbigner just to confirm.

[DennisHeimbigner]

You are correct, although it may have overtaken by a later change,

[ckhroulev]

You are correct, although it may have overtaken by a later change,

Not in the master branch - I checked before I opened this issue.

Note, though, that c0, c1, and s1 should also be removed now that there's no need cast away const (see #1486 and #1495).