Make the dap4 code resistant to various server errors. #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some versions of some servers are returning malformed responses. Make the library either handle them or gracefully fail. The three server errors "fixed" here are as follows. 1. The attribute _NCProperties sometimes has a trailing nul character in its value. Soln is to elide the nul(s). 2. Sometimes a DAP response has no data part, only a DMR. Soln is to detect and return an error code instead of crashing. 3. Sometimes a server returns a redirection, but our current openmagic() function was not following the redirect. Soln is to follow redirects. Also because of Unidata#2, I am temporarily making --disable-dap-remote-tests be the default.
WardF
approved these changes
Jan 8, 2020
|
Thanks @DennisHeimbigner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of some servers are returning malformed responses.
Make the library either handle them or gracefully fail.
The three server errors "fixed" here are as follows.
in its value. Soln is to elide the nul(s).
Soln is to detect and return an error code instead of crashing.
openmagic() function was not following the redirect. Soln
is to follow redirects.
Also because of Use GNUInstallDirs to install into /usr/lib64 as needed #2, I am temporarily making --disable-dap-remote-tests
be the default.