Use GNUInstallDirs to install into /usr/lib64 as needed #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you very much Orion! |
DennisHeimbigner
pushed a commit
that referenced
this pull request
Mar 9, 2014
should be under ENABLE_DAP_REMOTE_TESTS. Fixed to make sure that this is so. Also attempted to fix ncdap_test/CMakeLists.txt, but probably got it wrong. HT to Nico Schlomer. 2. Attempted to reduce the number of conversion errors when -Wconversion is set. Fixed oc2, but rest of netcdf remains to be done. HT to Nico Schlomer. 3. When doing #2, I discovered an error in ncgen.y that has remained hidden. This required some other test case fixes.
WardF
pushed a commit
that referenced
this pull request
Jul 29, 2014
7 tasks
4 tasks
DennisHeimbigner
added a commit
that referenced
this pull request
Aug 29, 2017
generates garbage. This in turn interferes with using .netrc because the garbage user+pwd can will override the .netrc. Note that this may work ok sometimes if the garbage happens to start with a nul character. 2. It turns out that the user:pwd combination needs to support character escaping. One reason is the user may contain an '@' character. The other is that modern password rules make it not unlikely that the password will contain characters that interfere with url parsing. So, the rule I have implemented is that all occurrences of the user:pwd format must escape any dodgy characters. The escape format is URL escaping of the form %XX. This applies both to user:pwd embedded in a URL as well as the use of HTTP.CREDENTIALS.USERPASSWORD in a .dodsrc/.daprc file. The user and password in .netrc must not be escaped. This is now documented in docs/auth.md The fix for #2 actually obviated #1. Now, internally, the user and pwd are stored separately and not in the user:pwd format. They are combined (and escaped) only when needed.
edhartnett
referenced
this pull request
in NetCDF-World-Domination-Council/netcdf-c
Jan 30, 2018
WardF
pushed a commit
that referenced
this pull request
Feb 3, 2018
DennisHeimbigner
added a commit
to DennisHeimbigner/netcdf-c
that referenced
this pull request
Jan 8, 2020
Some versions of some servers are returning malformed responses. Make the library either handle them or gracefully fail. The three server errors "fixed" here are as follows. 1. The attribute _NCProperties sometimes has a trailing nul character in its value. Soln is to elide the nul(s). 2. Sometimes a DAP response has no data part, only a DMR. Soln is to detect and return an error code instead of crashing. 3. Sometimes a server returns a redirection, but our current openmagic() function was not following the redirect. Soln is to follow redirects. Also because of Unidata#2, I am temporarily making --disable-dap-remote-tests be the default.
LProx2020
referenced
this pull request
in LProx2020/netcdf-c
Jul 21, 2020
More fixes in collaboration with I.P. - Check to see if the spacing for the ArcGIS paragraph is correct - Check to see if the spacing for the AgriMetSoft NetCDF-Extractor is correct * Did not address broken links, but should address both broken links and links that re-direct to unintended webpages
LProx2020
referenced
this pull request
in LProx2020/netcdf-c
Jul 23, 2020
More fixes in collaboration with I.P. * Did not fix spacing for the ArcGIS nor AgriMetSoft sections * Did not address broken links, but should address both broken links and links that re-direct to unintended webpages
ZedThree
pushed a commit
to ZedThree/netcdf-c
that referenced
this pull request
Feb 22, 2024
Cmake hdf5 tidy 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Fedora, libraries get installed into /usr/lib64. This change uses the GNUInstallDirs cmake module to handle this automatically.