Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias stringlength url parameter and maxstrlen #619

Merged
merged 9 commits into from
May 21, 2018
Merged

Alias stringlength url parameter and maxstrlen #619

merged 9 commits into from
May 21, 2018

Conversation

DennisHeimbigner
Copy link
Collaborator

re: esupport AVS-567793

Some parameters like stringlength actually affect a dimension
named maxStrlen. So, add some aliasing so maxstrlen can be
specified as a parameter and as an alias for stringlength.

The affected parameters (case insensitive):
stringlength has alias maxstrlen
stringlength_ has alias maxstrlen_

Also:

  1. added a test case in ncdap_test/testurl.sh
  2. added note to documentation

Some parameters like stringlength actually affect a dimension
named maxStrlen.  So, add some aliasing so maxstrlen can be
specified as a parameter and as an alias for stringlength.

The affected parameters (case insensitive):
stringlength has alias maxstrlen
stringlength_<varname> has alias maxstrlen_<varname>

Also:
1. added a test case in ncdap_test/testurl.sh
2. added note to documentation
@WardF WardF self-requested a review as a code owner April 2, 2018 19:55
@WardF
Copy link
Member

WardF commented May 18, 2018

Still need to diagnose the issue, but I am seeing a lot of coredumps when I try to run tests on this branch. I'd suggest it's relatively low priority to get this in, but this is why it's currently languishing. I'll see if I can get a cdash output submitted and, if so, will post a link to the verbose results.

@WardF
Copy link
Member

WardF commented May 18, 2018

Output is here: http://cdash.unidata.ucar.edu/viewTest.php?onlyfailed&buildid=2491

It is not particularly useful; the failures stem from failed diff comparisons. The underlying cause for the diff failure is a core dump/crash when the underlying script invokes one of the utilities (I haven't tracked it down yet, just trying to get this info written down).

@DennisHeimbigner
Copy link
Collaborator Author

Last travis output seems to indicate a memory allocation error.

@DennisHeimbigner
Copy link
Collaborator Author

There was some kind of duplicated code problem that was causing all sorts of
problems. Anyway, sorted it out and merged master.

@WardF WardF merged commit 2a9eaff into master May 21, 2018
@WardF WardF deleted the dapparams.dmh branch May 21, 2018 19:43
@WardF
Copy link
Member

WardF commented May 21, 2018

Excellent, thanks Dennis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants