Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple vars with different chunks on the same unlimited dim #760

Merged
merged 3 commits into from
Jan 25, 2018

Conversation

Lnaden
Copy link
Contributor

@Lnaden Lnaden commented Jan 2, 2018

Fix #299
The conditions to make this error are the following:

  • Two variables with different chunk sizes
  • Both variables write on the same unlimited dimension
  • The first variable has already written data when the second variable is created

Fix Unidata#299
The conditions to make this error are the following:
* Two variables with different chunk sizes
* Both variables write on the same unlimited dimension
* The first variable has already written data when the second variable is created
@CLAassistant
Copy link

CLAassistant commented Jan 2, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@edhartnett edhartnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. Also nice test.

@WardF WardF self-assigned this Jan 2, 2018
@WardF WardF added this to the 4.6.0 milestone Jan 2, 2018
@Lnaden
Copy link
Contributor Author

Lnaden commented Jan 3, 2018

Do I need to merge the upstream master into my fork and push the changes to this PR, or is there a different procedure you would like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants