-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the analysis storage chunk equal to checkpoint interval #861
Conversation
Self-explanatory. Some variables are not chunked to the checkpoint_interval because they are not accessed in bulk usually (online free energy, timestamp). This is an optimization for read/write. Fixes #860
I'd chunk anything that is written each iteration to the same interval. Otherwise, we won't get the speed benefit from not having to enlarge the file each iteration. |
Fair. The only one I would need to change then is the |
This is currently throwing errors due to the following problem: Given that this has been open now for a year and a half, I'm not sure if it will ever be fixed. |
The code is here. I guess we're stuck with chunksizes of 1 for now, but it would be worth contributing what must be the trivial change to fix this back to Unidata. |
It looks like you just need to modify line 1081 if(var->dim[d]->len > 0 && chunksizes[d] > var->dim[d]->len) to if(!var->dim[d]->unlimited && var->dim[d]->len > 0 && chunksizes[d] > var->dim[d]->len) Maybe we should try to fix it for them? |
@jchodera I had just written that up on the parent issue Unidata/netcdf-c#299 then came back here and saw the post. I'll see what they say about any pitfalls in chunking 2 variables on the same dimension differently with existing data. |
@Lnaden has proposed a PR fix in Unidata/netcdf-c#760 |
@Lnaden : Can you revive this PR for the |
Superseded by #912, closing |
Self-explanatory. Some variables are not chunked to the checkpoint_interval because they are not accessed in bulk usually (online free energy, timestamp).
This is an optimization for read/write.
Fixes #860