Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt: check for the C types that match Fortran ones. #67

Merged
merged 3 commits into from
May 18, 2018

Conversation

multiplemonomials
Copy link
Contributor

When I was integrating netcdf-fortran into Amber-MD's build system, I noticed that the ENABLE_FORTRAN_TYPE_CHECKS block in CMakeLists.txt (which seems important for portability) was marked as TODO. Since my CMake-ized PNetcdf also needed this feature, I wrote it for you guys. I have tested it on several machines and it seems to work fine.

I also made two other small changes to CMakeLists.txt: I removed the unnecessary full include paths to standard library modules, and I removed QUIET from the find_package(netCDF) call. This makes it so the user gets a lot more information if it can't find netcdf.

Let me know if you have any questions or concerns.

@multiplemonomials
Copy link
Contributor Author

Hmm, I signed the CLA, but it's still showing as "not signed yet". Any idea what's going on?

@WardF
Copy link
Member

WardF commented Sep 28, 2017

No idea, I did not know this had been enabled. I will ask out CLA admin.

@WardF
Copy link
Member

WardF commented Sep 28, 2017

@dopplershift Any idea what might be happening in this case?

@multiplemonomials
Copy link
Contributor Author

Oh huh, it seems to be fixed now. I guess there was some sort of time lag? Anyway, how does this PR look to you guys?

@dopplershift
Copy link
Member

Some times GitHub's hook delivery can be a bit delayed. It looks like everything is fine now. Let me know if you run into any other problems!

@multiplemonomials
Copy link
Contributor Author

So, what is the status of this PR? Is it under review? Are there any changes that you need me to make?

@WardF
Copy link
Member

WardF commented Oct 2, 2017

I'm currently working on the 4.5.0 release, and answering support questions. I'll take a look at this ASAP, thanks!

@WardF WardF self-assigned this Feb 14, 2018
@WardF WardF added this to the 4.4.5 milestone Feb 14, 2018
@WardF
Copy link
Member

WardF commented Feb 14, 2018

Being reviewed by our new fortran contributor/dev @piqueen314 for inclusion; getting the next release out in short order is high priority.

@WardF WardF merged commit 000aebe into Unidata:master May 18, 2018
WardF added a commit that referenced this pull request May 18, 2018
Github #67 plus a couple other small changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants