Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompositeStationCollection leaves files locked #320

Closed
lesserwhirls opened this issue Jun 9, 2020 · 0 comments · Fixed by #321
Closed

CompositeStationCollection leaves files locked #320

lesserwhirls opened this issue Jun 9, 2020 · 0 comments · Fixed by #321
Labels
bug Something isn't working

Comments

@lesserwhirls
Copy link
Collaborator

There are cases where the code in CompositeStationCollection will leave a FileCachable locked as it searches through a multifile collection for Station Features, specifically when that feature does not exist in a given file. This was first noticed on the TDS side (see Unidata/tds#88).
lesserwhirls added a commit to lesserwhirls/netcdf-java that referenced this issue Jun 9, 2020
@lesserwhirls
Demonstrate CompositeStationCollection cache locks
d1a64d3 
See Unidata/tds#88, Unidata#320
lesserwhirls added a commit to lesserwhirls/netcdf-java that referenced this issue Jun 9, 2020
@lesserwhirls
Close Datasets that do not have the StationFeature sought
09db820 
Make sure that datasets that do not contain a given StationFeature
are release/closed, otherwise, if one or more caches are enabled (i.e.
NetcdfDataset's NetcdfFile Cache or RandomAccessFile's cache), the
file handle will be locked and new file handles will be opened each
pass through the collection. These exist in the cache until the OS runs
out of file handles, or until the cache is forcefully purged, and we
all have a bad time when that happens.

Fixes Unidata#320
@lesserwhirls lesserwhirls mentioned this issue Jun 9, 2020
Merged
@lesserwhirls lesserwhirls added the bug Something isn't working label Jun 9, 2020
lesserwhirls added a commit to lesserwhirls/tds that referenced this issue Jun 10, 2020
@lesserwhirls
featureCollection featureType Station file handles
367c989 
Add a test to the TDS to make sure the bug in Unidata/netcdf-java#320
is fixed when CompositeStationCollection is used by a featureCollection
featureType=Station collection.
lesserwhirls added a commit to lesserwhirls/tds that referenced this issue Jun 10, 2020
@lesserwhirls
featureCollection featureType Station file handles
3e1c5e5 
Add a test to the TDS to make sure the bug in Unidata/netcdf-java#320
is fixed when CompositeStationCollection is used by a featureCollection
featureType=Station collection (see Unidata#88)
@lesserwhirls lesserwhirls mentioned this issue Jun 10, 2020
Merged
lesserwhirls added a commit to lesserwhirls/thredds that referenced this issue Jun 10, 2020
@lesserwhirls
Backport of CompositeStationCollection fixes
c27c331 
Back port of Unidata/netcdf-java#320, Unidata/tds#89
lesserwhirls added a commit to lesserwhirls/tds that referenced this issue Jun 10, 2020
@lesserwhirls
featureCollection featureType Station file handles
88cdf94 
Add a test to the TDS to make sure the bug in Unidata/netcdf-java#320
is fixed when CompositeStationCollection is used by a featureCollection
featureType=Station collection (see Unidata#88)
@lesserwhirls lesserwhirls mentioned this issue Jun 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CompositeStationCollection dangling file locks lesserwhirls/netcdf-java
1 participant
@lesserwhirls