Point Collection FeatureCollections update working #413
Conversation
| // | ||
| UpdateableCollection uc = (UpdateableCollection) fd; | ||
| have = uc.update(); | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
Probably need to log an error on the IOException and catch (and swallow) any errors from casting to UpdatableCollection.
There was a problem hiding this comment.
Ok, this should be fixed in the updated PR. Thanks!
On Monday, February 8, 2016, Ryan May notifications@github.com wrote:
In tds/src/main/java/thredds/server/ncss/params/NcssParamsBean.java
#413 (comment):@@ -405,6 +407,20 @@ public boolean isValidGridRequest() {
public boolean intersectsTime(FeatureDataset fd, Formatter errs) throws ParseException {
CalendarDateRange have = fd.getCalendarDateRange();
- try {
//// if this is an updatable collection, check for a new CalendarDateRange (i.e. new// data available).// The issue is that fd does not get updated with thredds.catalog.InvDatasetFcPoint//// This allows requests to be fulfilled, even if the correct CalendarDateRange is// not available in the catalog. Ideally these should be synced.//UpdateableCollection uc = (UpdateableCollection) fd;have = uc.update();- } catch (IOException e) {
Probably need to log an error on the IOException and catch (and swallow)
any errors from casting to UpdatableCollection.—
Reply to this email directly or view it on GitHub
https://github.com/Unidata/thredds/pull/413/files#r52215923.
Fixed Unidata#378 The update function would update the local state of the available date/time range of the dataset in the catalog, but this was not being properly checked in the request validation. Note that this essentially doubles the check of the date/time range.
Point Collection FeatureCollections update working
Fixed #378
The update function would update the local state of the available date/time range
of the dataset in the catalog, but this was not being properly checked in the
request validation. Note that this will not scale well, as the validation bean
checks the date/time range on the CompositePointDataset object, which only gets
updated on server restart.