Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serial-control.py #63

Merged
merged 1 commit into from Apr 7, 2015

Conversation

electronicamystica
Copy link
Contributor

Added Temp2 + Temp3 to the graph.
Added behind the 4 other temperatures so colours for Setpoint and Coldjunction don't change
Uncomment when needed.
Maybe using X1/X2 as label instead of Temp2/Temp3?

Added Temp2 + Temp3 to the graph. 
Added behind the 4 other temperatures so colours for Setpoint and Coldjunction don't change
Uncomment when needed.
@jieter
Copy link
Contributor

jieter commented Mar 1, 2015

Yes, we should add those. Keeping the same names in firmware and host-PC is the way to go I think, so we should change Temp0/Temp1 to L/R in python script, or change them in the firmware too, because for my oven, L/R makes no sense, as they are placed front/back.

I think it's nice if the script detects non-zero values for X1/X2 and automagically adds them to the graph.

@xnk
Copy link
Member

xnk commented Apr 7, 2015

I'll go ahead and merge this. I've been thinking about the naming, maybe the easiest thing would be to have two different names for the first two sensors which can be configured as a setup item (L/R or F/B) and then keep X1 and X2. In either case those should then be the names used by the oven in the serial output and serial-control.py might then be able to pick the names up from the header?

xnk added a commit that referenced this pull request Apr 7, 2015
@xnk xnk merged commit ec4e5c8 into UnifiedEngineering:master Apr 7, 2015
@jieter
Copy link
Contributor

jieter commented Apr 7, 2015

Yes, oven should report available sensors in some parsable format so the python script can decide what values to display automatically. Names could be parsed from the header of course, the the script needs some refactoring after the serial stuff is more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants