Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #34 and #39 #40

Merged
merged 7 commits into from Jan 31, 2015
Merged

Fixes for #34 and #39 #40

merged 7 commits into from Jan 31, 2015

Commits on Jan 22, 2015

  1. Cleaned Up Program, removed System.exit(), see #34

    - Main now also uses spaces for padding
    - Main is now responsible for wiring commands to the bot.
    - Any bot extending AbstractBot can now be shut down by enqueuing a Poison-Pill to them
    - Default Bot logger made static
    - Made Program less brittle on startup for JavaDocAccessor
    - Allowed Injecting ChatInterface to Program via Constructor
    - Moved shutdown Command to CoreBotCommands
    - Exposed querying thread ExecutorService from Program
    - Program also holds the Poison-Pill
    - Removed System.exit from shutdown command
    - Exposed Bot instance from Program
    Vogel612 committed Jan 22, 2015
    Configuration menu
    Copy the full SHA
    043ab55 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    18d89a6 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2015

  1. Added proper shutdown mechanisms for classes extending AbstractBot, see

    #39
    
    - Removed executor shutdowns in #finalize()
    - Added protected #shutdown() method to AbstractBot that allows extending classes to clean up threads they introduce themselves
    Vogel612 committed Jan 24, 2015
    Configuration menu
    Copy the full SHA
    e2001df View commit details
    Browse the repository at this point in the history
  2. Message Querying Thread now is a daemon thread, see #39

    - Main is now responsible for firing up a Thread responsible for querying
    - Removed executor from Program
    - Added Logger to Main
    - Removed superfluous shutdown call in createShutdownCommand()
    Vogel612 committed Jan 24, 2015
    Configuration menu
    Copy the full SHA
    96bab53 View commit details
    Browse the repository at this point in the history
  3. Removed logging in from Program's responsibility

    - Extracted "safe" message querying to it's own method
    - Made use of ChatInterface's AutoCloseable to handle resources
    - Added clarifying javadoc to what assumptions are made about the chatInterface's state when it's passed to Program
    Vogel612 committed Jan 24, 2015
    Configuration menu
    Copy the full SHA
    b5a0f37 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8aa4ea0 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2015

  1. Merge branch 'master' into develop

    Conflicts:
    	src/main/java/com/gmail/inverseconduit/bot/Program.java
    Vogel612 committed Jan 28, 2015
    Configuration menu
    Copy the full SHA
    7490bd5 View commit details
    Browse the repository at this point in the history