New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for #34 and #39 #40
Commits on Jan 22, 2015
-
Cleaned Up Program, removed System.exit(), see #34
- Main now also uses spaces for padding - Main is now responsible for wiring commands to the bot. - Any bot extending AbstractBot can now be shut down by enqueuing a Poison-Pill to them - Default Bot logger made static - Made Program less brittle on startup for JavaDocAccessor - Allowed Injecting ChatInterface to Program via Constructor - Moved shutdown Command to CoreBotCommands - Exposed querying thread ExecutorService from Program - Program also holds the Poison-Pill - Removed System.exit from shutdown command - Exposed Bot instance from Program
Configuration menu - View commit details
-
Copy full SHA for 043ab55 - Browse repository at this point
Copy the full SHA 043ab55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18d89a6 - Browse repository at this point
Copy the full SHA 18d89a6View commit details
Commits on Jan 24, 2015
-
Added proper shutdown mechanisms for classes extending AbstractBot, see
#39 - Removed executor shutdowns in #finalize() - Added protected #shutdown() method to AbstractBot that allows extending classes to clean up threads they introduce themselves
Configuration menu - View commit details
-
Copy full SHA for e2001df - Browse repository at this point
Copy the full SHA e2001dfView commit details -
Message Querying Thread now is a daemon thread, see #39
- Main is now responsible for firing up a Thread responsible for querying - Removed executor from Program - Added Logger to Main - Removed superfluous shutdown call in createShutdownCommand()
Configuration menu - View commit details
-
Copy full SHA for 96bab53 - Browse repository at this point
Copy the full SHA 96bab53View commit details -
Removed logging in from Program's responsibility
- Extracted "safe" message querying to it's own method - Made use of ChatInterface's AutoCloseable to handle resources - Added clarifying javadoc to what assumptions are made about the chatInterface's state when it's passed to Program
Configuration menu - View commit details
-
Copy full SHA for b5a0f37 - Browse repository at this point
Copy the full SHA b5a0f37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8aa4ea0 - Browse repository at this point
Copy the full SHA 8aa4ea0View commit details
Commits on Jan 28, 2015
-
Merge branch 'master' into develop
Conflicts: src/main/java/com/gmail/inverseconduit/bot/Program.java
Configuration menu - View commit details
-
Copy full SHA for 7490bd5 - Browse repository at this point
Copy the full SHA 7490bd5View commit details