Fixes for #34 and #39 #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Main now also uses spaces for padding - Main is now responsible for wiring commands to the bot. - Any bot extending AbstractBot can now be shut down by enqueuing a Poison-Pill to them - Default Bot logger made static - Made Program less brittle on startup for JavaDocAccessor - Allowed Injecting ChatInterface to Program via Constructor - Moved shutdown Command to CoreBotCommands - Exposed querying thread ExecutorService from Program - Program also holds the Poison-Pill - Removed System.exit from shutdown command - Exposed Bot instance from Program
#39 - Removed executor shutdowns in #finalize() - Added protected #shutdown() method to AbstractBot that allows extending classes to clean up threads they introduce themselves
- Main is now responsible for firing up a Thread responsible for querying - Removed executor from Program - Added Logger to Main - Removed superfluous shutdown call in createShutdownCommand()
- Extracted "safe" message querying to it's own method - Made use of ChatInterface's AutoCloseable to handle resources - Added clarifying javadoc to what assumptions are made about the chatInterface's state when it's passed to Program
|
After clearing this with Uni, I've decided to adapt this to the latest changes by Michael. Then a review will follow |
Conflicts: src/main/java/com/gmail/inverseconduit/bot/Program.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a shutdown mechanism as Poison Pill
Made all threads shut down slowly and cleanly when calling shutdown
Cleaned up Program by allowing the injection of ChatInterface (which has to be logged in already)
Updated gitignore a little to accomodate javadoc zip-files