Upgrade python-ldap #1728
Merged
Upgrade python-ldap #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldap library should now be present also under python 3, and tests should always run avoid use of str, since it's ambivalent
…ding we need, however, to decode result values according to the configured encoding, since values will still be bytestrings.
jmbredal
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New versions of
python-ldapwere introduced earlier in 2018 which support Python 3. This enables us to move forward with our push towards Python 3.This sets out to upgrade the
python-ldapdependency and updating the codebase to work on both Python 2 and 3. This document was very useful in doing so:https://github.com/python-ldap/python-ldap/blob/3.0/Doc/bytes_mode.rst