Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add related names to django models (cabling, event) #2540

Merged
merged 4 commits into from Jan 11, 2023
Merged

Add related names to django models (cabling, event) #2540

merged 4 commits into from Jan 11, 2023

Conversation

johannaengland
Copy link
Contributor

This is the second part of splitting up #2423.

@johannaengland johannaengland self-assigned this Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023 •
edited

Codecov Report

Merging #2540 (2993c3f) into master (9e16ace) will not change coverage.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##           master    #2540   +/-   ##
=======================================
  Coverage   53.42%   53.42%           
=======================================
  Files         555      555           
  Lines       40382    40382           
=======================================
  Hits        21573    21573           
  Misses      18809    18809
Impacted Files Coverage Δ
python/nav/models/event.py 79.73% <ø> (ø)
python/nav/models/service.py 56.25% <0.00%> (ø)
python/nav/models/manage.py 71.53% <50.00%> (ø)
python/nav/models/cabling.py 89.65% <100.00%> (ø)
python/nav/web/ipdevinfo/views.py 40.88% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jan 5, 2023 •
edited

Test results

     12 files       12 suites   12m 50s ⏱️
3 186 tests 3 090 ✔️   96 💤 0 ❌
9 033 runs  8 745 ✔️ 288 💤 0 ❌

Results for commit 2993c3f.

♻️ This comment has been updated with latest results.

lunkwill42
lunkwill42 requested changes Jan 10, 2023
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a grammar nitpick, everything else looks fine :)

python/nav/models/cabling.py Outdated Show resolved Hide resolved
lunkwill42
lunkwill42 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johannaengland johannaengland merged commit 61c9acc into Uninett:master Jan 11, 2023
@johannaengland johannaengland deleted the related-names-2 branch January 11, 2023 12:34
@johannaengland johannaengland mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

@hmpf hmpf Awaiting requested review from hmpf

@stveit stveit Awaiting requested review from stveit

Assignees

@johannaengland johannaengland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johannaengland @lunkwill42