New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add related names to django models #2423
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2423 +/- ##
==========================================
+ Coverage 52.64% 52.70% +0.06%
==========================================
Files 552 552
Lines 40167 40186 +19
==========================================
+ Hits 21144 21180 +36
+ Misses 19023 19006 -17
Continue to review full report at Codecov.
|
3c9e7ee
to
caf7e2e
Compare
caf7e2e
to
bea3ce2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. What a beast. Other than my multiple inline comments, I have two requests for the future:
- Please break things like this into multiple PRs. It's a nightmare to review and keep track of changes underway.
- Please do not force-push changes after a review. Adding more commits makes it easier to see what has changed since the last review - and everything can be squashed once approved.
The force push was because of a rebase onto master |
bea3ce2
to
4530f50
Compare
Should be fixed now - Github tried to hide these comments from me 😄 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Due to the massive size of this PR I have split it up into several smaller ones. |
Closes #2418
Will squash the commits together after reviews