Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add related names to django models (manage - Switch/topology) #2550

Merged
merged 10 commits into from Mar 2, 2023

Conversation

johannaengland
Copy link
Contributor

This is the ninth part of splitting up #2423.

@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #2550 (c9c8432) into master (89811b2) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2550      +/-   ##
==========================================
- Coverage   53.76%   53.73%   -0.04%     
==========================================
  Files         558      558              
  Lines       40588    40588              
==========================================
- Hits        21824    21811      -13     
- Misses      18764    18777      +13     
Impacted Files Coverage Δ
python/nav/eventengine/plugins/linkstate.py 26.27% <0.00%> (ø)
python/nav/models/profiles.py 69.53% <ø> (ø)
python/nav/portadmin/napalm/juniper.py 45.88% <0.00%> (ø)
python/nav/portadmin/snmp/base.py 46.68% <0.00%> (ø)
python/nav/topology/detector.py 50.50% <0.00%> (ø)
python/nav/topology/vlan.py 27.12% <ø> (ø)
python/nav/web/ipdevinfo/utils.py 23.37% <ø> (ø)
python/nav/web/networkexplorer/mixins.py 27.51% <0.00%> (ø)
python/nav/web/portadmin/views.py 14.97% <0.00%> (ø)
python/nav/models/manage.py 71.51% <66.66%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Test results

     12 files       12 suites   11m 1s ⏱️
3 222 tests 3 126 ✔️   96 💤 0
9 141 runs  8 853 ✔️ 288 💤 0

Results for commit c9c8432.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov is being annoying. Also, see one question.

@hmpf hmpf self-requested a review March 2, 2023 13:07
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johannaengland johannaengland merged commit 549ffc0 into Uninett:master Mar 2, 2023
9 of 11 checks passed
@johannaengland johannaengland deleted the related-names-9 branch March 2, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants