-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple tests for search #2597
Add simple tests for search #2597
Conversation
Kudos, SonarCloud Quality Gate passed!
|
de276ca
to
96cdabb
Compare
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2597 +/- ##
==========================================
+ Coverage 54.20% 54.41% +0.21%
==========================================
Files 558 558
Lines 40634 40634
==========================================
+ Hits 22026 22112 +86
+ Misses 18608 18522 -86 see 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
As mentioned before in #2595 adding related names broke something in the room search. This PR adds tests for the different searches. As a nice side effect I also discovered a bug that was fixed in #2596.