Version lock indirect dependencies of our test suites #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`snmpsim` depends on `pyasn1`, but does not lock the dependent version. `pyasn1` version 0.5.0 was recently released, and it seems `snmpsim` is incompatible with the new version, causing integration tests that use snmpsim to fail. This locks pyasn1 to a version that should still work with the latest version of snmpsim.
`selenium` and `requests` depend on `urllib3`, which recently released version 2.0. The version of selenium we are using for driving our functional tests doesn't appear to be compatible with this new major version, causing all selenium-based tests to fail.
|
Kudos, SonarCloud Quality Gate passed!
|
hmpf
approved these changes
May 24, 2023
Codecov Report
@@ Coverage Diff @@
## master #2622 +/- ##
==========================================
+ Coverage 54.20% 54.25% +0.05%
==========================================
Files 558 558
Lines 40627 40722 +95
==========================================
+ Hits 22020 22092 +72
- Misses 18607 18630 +23 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of the libraries we utilize as part of our test suite have seen their dependencies be released in new versions that are no longer compatible.
This PR locks those indirect dependencies to versions that are know to work for us.
Fixes #2617