Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version lock indirect dependencies of our test suites #2622

Merged
merged 2 commits into from
May 24, 2023
Merged

Version lock indirect dependencies of our test suites #2622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72f241a
Lock pyasn1<0.5.0
lunkwill42 May 24, 2023
eea73ef
Lock urllib3<2.0
lunkwill42 May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: "Install test runner dependencies"
run: |
set -xe
python -m pip install --upgrade pip setuptools wheel 'tox<4' tox-gh-actions coverage virtualenv snmpsim
python -m pip install --upgrade pip setuptools wheel 'tox<4' tox-gh-actions coverage virtualenv snmpsim 'pyasn1<0.5.0'
sudo apt-get install -y nbtscan

# virtualenv seems to currently be embedding a broken version of
Expand Down
2 changes: 1 addition & 1 deletion tests/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ RUN cd /tmp && \
mv chromedriver /usr/local/bin/

# Install our primary test runner
RUN python3.7 -m pip install 'tox<4' snmpsim virtualenv
RUN python3.7 -m pip install 'tox<4' snmpsim 'pyasn1<0.5.0' virtualenv

# Add a build user
ENV USER build
Expand Down
2 changes: 2 additions & 0 deletions tests/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,5 @@ whitenoise==4.1.4
# the next dep is here because newer versions of ciscoconfparse has broken dependencies
# this can be removed once we move to napalm 4, which no longer depends on ciscoconfparse
ciscoconfparse<1.6.51
# Our version of selenium breaks down if it is allowed to pull in the newest version of urllib3
urllib3<2.0