Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for JWT configuration #2627

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add doc for JWT configuration #2627

wants to merge 9 commits into from

Conversation

stveit
Copy link
Contributor

@stveit stveit commented May 26, 2023

Fixes #2618

Adds docs for how to configure JWTs, how to use them and requirements for them to be valid.

@stveit stveit self-assigned this May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.19%. Comparing base (9bfd62f) to head (9a98a13).

❗ Current head 9a98a13 differs from pull request most recent head 608841a. Consider uploading reports for the commit 608841a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2627      +/-   ##
==========================================
- Coverage   56.60%   55.19%   -1.42%     
==========================================
  Files         601      561      -40     
  Lines       43981    40917    -3064     
==========================================
- Hits        24896    22584    -2312     
+ Misses      19085    18333     -752     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented May 26, 2023

Test results

       8 files         8 suites   7m 12s ⏱️
3 318 tests 3 318 ✔️ 0 💤 0
6 368 runs  6 368 ✔️ 0 💤 0

Results for commit 608841a.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stveit stveit marked this pull request as ready for review May 26, 2023 12:03
@hmpf hmpf self-requested a review July 26, 2023 10:12
doc/howto/using_the_api.rst Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stveit
Copy link
Contributor Author

stveit commented Nov 13, 2023

Docs build fails. From the errors it seems like it fails when trying to checkout the most recent commit in this PR on the Uninett/nav repo. But my commits are technically on my own , stveit/nav repo. Is that why it fails?

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems mostly fine to me, just nitpicks on markup, really :)

doc/reference/jwt.rst Outdated Show resolved Hide resolved
doc/reference/jwt.rst Outdated Show resolved Hide resolved
doc/reference/jwt.rst Outdated Show resolved Hide resolved
doc/reference/jwt.rst Outdated Show resolved Hide resolved
doc/howto/using_the_api.rst Outdated Show resolved Hide resolved
@lunkwill42
Copy link
Member

Docs build fails. From the errors it seems like it fails when trying to checkout the most recent commit in this PR on the Uninett/nav repo. But my commits are technically on my own , stveit/nav repo. Is that why it fails?

Nah, that shouldn't be a problem. But strange Heissenbugs are abound. Retrying the check sometimes helps..

@lunkwill42
Copy link
Member

Docs build fails. From the errors it seems like it fails when trying to checkout the most recent commit in this PR on the Uninett/nav repo. But my commits are technically on my own , stveit/nav repo. Is that why it fails?

Nah, that shouldn't be a problem. But strange Heissenbugs are abound. Retrying the check sometimes helps..

Seems this was fixed on master back in August: e34446c

Rebasing on the latest master would help...

Co-authored-by: Morten Brekkevold <morten.brekkevold@sikt.no>
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document JWT configuration in NAV
3 participants