-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle invalid alert address in alert sending #2661
Handle invalid alert address in alert sending #2661
Conversation
Codecov Report
@@ Coverage Diff @@
## 5.6.x #2661 +/- ##
==========================================
+ Coverage 54.13% 54.17% +0.04%
==========================================
Files 558 558
Lines 40641 40647 +6
==========================================
+ Hits 22000 22021 +21
+ Misses 18641 18626 -15
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the implementation of the address validation itself - but the rest looks peachy :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
ff071d7
to
c666afd
Compare
Kudos, SonarCloud Quality Gate passed! |
When we try to send an alert, but the alert address is empty currently no alert is sent, an error is logged, but it is reported back as a successful sending, which can become very confusing.
This PR fixes that and even widens the application. Before sending an alert the address it is to be sent to is validated and in case it is invalid an error is logged and an
InvalidAlertAddressError
is thrown. That is caught further up and the alert is deleted in that case and the sending is reported back as failed.This popped up due to #1787.