Add SNMPv3 support to Portadmin #2731
Conversation
lunkwill42
force-pushed
the
feature/snmpv3-portadmin
branch
from
ae8f547
to
349caaa
Compare
Netbox.get_preferred_snmp_manage_profile() should be trusted to return a proper SNMP profile. I see no reason to guard against faulty return values like this.
Lets the utility function set up the SNMP session for SNMPHandler based management handlers in PortAdmin.
The profile fixture returned a mocked management profile object that was incomplete. The new SNMP setup routines inspect the profile configuration more closely, and would fail. There is no need to use a Mock to mock a profile, just create an instance with an actual configuration dict, but just don't save it anywhere.
lunkwill42
force-pushed
the
feature/snmpv3-portadmin
branch
from
eef0401
to
9ca27c5
Compare
|
Changes to Portadmin and its tests were recently merged to master, and my latest changes were in conflict with these. Had to force-push an updated version to make things mergeable. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2731 +/- ##
==========================================
- Coverage 55.46% 55.46% -0.01%
==========================================
Files 567 567
Lines 41175 41172 -3
==========================================
- Hits 22838 22836 -2
+ Misses 18337 18336 -1 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
Good point. Even though they are marked as unused by my IDE, we don't have linter rules that will trigger this (SonarCloud apparently doesn't, and our pylint setup is defunct). Pushed an extra commit for this cleanup. |
Tested successfully against our lab switches.
Closes #2712