Commits on Nov 16, 2023

1. Trust get_preferred_snmp_management_profile …

   Netbox.get_preferred_snmp_manage_profile() should be trusted to return
   a proper SNMP profile.  I see no reason to guard against faulty
   return values like this.

   

   lunkwill42 committed Nov 16, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 5368290
   • Browse repository at this point

   Copy the full SHA

   5368290 View commit details

   Browse the repository at this point in the history

2. Use get_snmp_session_for_profile() in SNMPHandler …

   Lets the utility function set up the SNMP session for SNMPHandler based
   management handlers in PortAdmin.

   

   lunkwill42 committed Nov 16, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for d028681
   • Browse repository at this point

   Copy the full SHA

   d028681 View commit details

   Browse the repository at this point in the history

3. Fix profile fixture …

   The profile fixture returned a mocked management profile object that
   was incomplete.  The new SNMP setup routines inspect the profile
   configuration more closely, and would fail.  There is no need to use
   a Mock to mock a profile, just create an instance with an actual
   configuration dict, but just don't save it anywhere.

   

   lunkwill42 committed Nov 16, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 9ca27c5
   • Browse repository at this point

   Copy the full SHA

   9ca27c5 View commit details

   Browse the repository at this point in the history

4. Remove unused imports.

   

   lunkwill42 committed Nov 16, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 493e595
   • Browse repository at this point

   Copy the full SHA

   493e595 View commit details

   Browse the repository at this point in the history