Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure alert profile tests #2739

Merged

Conversation

johannaengland
Copy link
Contributor

Dependent on #2738.

Open for other suggestions when it comes to making these tests clearer and neater.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a952e23) 55.46% compared to head (69dc6ba) 55.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2739   +/-   ##
=======================================
  Coverage   55.46%   55.46%           
=======================================
  Files         567      567           
  Lines       41172    41172           
=======================================
  Hits        22837    22837           
  Misses      18335    18335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 15, 2023

Test results

     12 files       12 suites   11m 26s ⏱️
3 256 tests 3 256 ✔️ 0 💤 0
9 243 runs  9 243 ✔️ 0 💤 0

Results for commit 69dc6ba.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johannaengland johannaengland merged commit 54449ed into Uninett:master Nov 17, 2023
13 checks passed
@johannaengland johannaengland deleted the tests/alert-profiles-restructure branch November 17, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants