Flush session on logout

[stveit]

Instead of deleting stuff from session manually, use flush function instead. This is how Django does stuff internally.
Also puts the code into its own function so it isnt spread several places

Makes changes that are awkward to test in unit tests, so some tests have been ported to integration tests

related to #2804

[github-actions]

Test results

     12 files       12 suites   11m 39s ⏱️
3 320 tests 3 320 ✔️ 0 💤 0 ❌
9 435 runs  9 435 ✔️ 0 💤 0 ❌

Results for commit 45cea1f.

♻️ This comment has been updated with latest results.

[stveit]

This needs some changes to testing and additional tests, so ill let it wait until #2813 is done, as that adds some useful test additions

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.18%. Comparing base (459cb29) to head (45cea1f).
Report is 30 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2828      +/-   ##
==========================================
+ Coverage   57.15%   57.18%   +0.02%     
==========================================
  Files         568      568              
  Lines       41282    41301      +19     
==========================================
+ Hits        23596    23617      +21     
+ Misses      17686    17684       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lunkwill42]

The functionality changes here seem fine (have not tested manually, yet), however, I have objections to the way the tests have been reorganized.

We try to adhere to a pattern where test modules are named after the Python modules they are testing. These modules do not exist in NAV, yet the new test modules seem to indicate they exist:

• nav.web.auth.ensure_account
• nav.web.auth.logout

If you have a need to group multiple tests for a single function or class (or group of co-operating functions), I find it's better to group those tests as methods in a class.

E.g.

class TestFoobar:
    def test_when_color_is_green_it_should_return_ok_status(self ...):
        ...

Something like this would tell me the function or functionality under test is Foobar, and the test names tell me something about which conditions are being tested and which behaviors are expected
.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud