Fix broken navclean and navsynctypes scripts
#2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the `test_binary_runs` test with `test_script_runs` test. The former would just enumerate all the modules present in the `nav.bin` packages, extract their test args and run them directly from that location. However, not all the scripts here are compatible with being invoked from a pip-installed bin-directory shim that calls their main method directly. I.e. this updates the test suite to attempt to call all the defined NAV scripts in the manner they would be run in an installed system, rather than in an artificial manner. This should detect additional problems with the scripts.
This required-but-unused argument to main prevented `navclean` from running properly when invoked from the binary shim installed by pip/setuptools. Fixes Uninett#2874
This required-but-unused argument to main prevented `navsynctypes` from running properly when invoked from the binary shim installed by pip/setuptools. The argparser is only there to provide a nice help screen if the `--help` argument is provided.
Python 3.7, damn you!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 5.9.x #2875 +/- ##
==========================================
- Coverage 56.70% 56.64% -0.07%
==========================================
Files 603 603
Lines 43983 43984 +1
==========================================
- Hits 24942 24916 -26
- Misses 19041 19068 +27 ☔ View full report in Codecov by Sentry. |
|
Python gets toml in the stdlib in 3.11: https://docs.python.org/3/library/tomllib.html Since we still can't run on 3.11 we don't need to hedge. Aside, we should copy direct dependencies from requirements.txt to pyproject.toml [project.dependencies], some other time. |
hmpf
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
navcleanandnavsynctypesscripts were broken in NAV 5.9.0, after the method of script installation was modernized.This PR changes the test suite to test-run the scripts defined for installation in
pyproject.toml, rather than running them in-place in thenav.binpackage, to ensure that they are truly compatible with being executed by end-users in an installed system.Fixes #2874