Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken navclean and navsynctypes scripts #2875

Merged
merged 4 commits into from Mar 15, 2024

Commits on Mar 15, 2024

  1. Test installed scripts instead of internal modules

    This replaces the `test_binary_runs` test with `test_script_runs` test.
    The former would just enumerate all the modules present in the `nav.bin`
    packages, extract their test args and run them directly from that
    location.  However, not all the scripts here are compatible with being
    invoked from a pip-installed bin-directory shim that calls their main
    method directly.
    
    I.e. this updates the test suite to attempt to call all the defined
    NAV scripts in the manner they would be run in an installed system,
    rather than in an artificial manner.  This should detect additional
    problems with the scripts.
    lunkwill42 committed Mar 15, 2024
    Copy the full SHA
    3197f4b View commit details
    Browse the repository at this point in the history
  2. Remove unused args from navclean.main()

    This required-but-unused argument to main prevented `navclean` from
    running properly when invoked from the binary shim installed by
    pip/setuptools.
    
    Fixes Uninett#2874
    lunkwill42 committed Mar 15, 2024
    Copy the full SHA
    db9d2c5 View commit details
    Browse the repository at this point in the history
  3. Remove unused args from navsynctypes.main()

    This required-but-unused argument to main prevented `navsynctypes` from
    running properly when invoked from the binary shim installed by
    pip/setuptools.  The argparser is only there to provide a nice help
    screen if the `--help` argument is provided.
    lunkwill42 committed Mar 15, 2024
    Copy the full SHA
    62b3ff9 View commit details
    Browse the repository at this point in the history
  4. fixup! Test installed scripts instead of internal modules

    Python 3.7, damn you!
    lunkwill42 committed Mar 15, 2024
    Copy the full SHA
    005d1aa View commit details
    Browse the repository at this point in the history