Avoid running command line scripts twice on every invocation #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a "double" shim to install these executable scripts, install their respective modules directly. The existing shim scripts would run the `main()` method as a side-effect of the module being imported, which was a bad idea. With the new script installation method, these commands would essentially run twice on every invocation.
This adds an import-time guard to ensure that `main()` isn't run twice when command is run through the install-time shim. Opted to leave this script in nav.bin, since it has pre-main setup that isn't in the imported module.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2878 +/- ##
==========================================
- Coverage 56.64% 56.60% -0.05%
==========================================
Files 603 601 -2
Lines 43984 43981 -3
==========================================
- Hits 24916 24896 -20
- Misses 19068 19085 +17 ☔ View full report in Codecov by Sentry. |
hmpf
reviewed
Mar 20, 2024
hmpf
previously approved these changes
Mar 20, 2024
hmpf
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2877