Make it possible to download a ZIP file containing QR codes of bulk selected netboxes/rooms #2899
+228
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannaengland
changed the title
johannaengland
force-pushed
the
feature/bulk-download-qr-codes
branch
from
afdc234
to
1bfc71e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2899 +/- ##
==========================================
+ Coverage 60.25% 60.31% +0.05%
==========================================
Files 602 602
Lines 44084 44138 +54
==========================================
+ Hits 26565 26623 +58
+ Misses 17519 17515 -4 ☔ View full report in Codecov by Sentry. |
johannaengland
force-pushed
the
feature/bulk-download-qr-codes
branch
2 times, most recently
from
d21e516
to
17bc18f
Compare
johannaengland
force-pushed
the
feature/bulk-download-qr-codes
branch
from
17bc18f
to
9d4bb24
Compare
johannaengland
force-pushed
the
feature/bulk-download-qr-codes
branch
from
9d4bb24
to
f75b9eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last step to #2586.
It does not currently offer the ZIP file to download. I was able to create the ZIP file and am able to access it in the frontend (which I've shown by setting the ZIP file as bytes as the source of the added anchor element), but I do not know how to make it possible for the user to download it from there.
Screenshots - before and after
Before:
After: