Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dict, List, Tuple and Type imports from Typing #2909

Merged

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented May 13, 2024

Dependent on #2949.

See https://peps.python.org/pep-0585/.
Since Python 3.9 one can simply use the build-in version.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.36%. Comparing base (3587764) to head (069b8d3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2909      +/-   ##
==========================================
- Coverage   56.36%   56.36%   -0.01%     
==========================================
  Files         601      601              
  Lines       43814    43809       -5     
  Branches       48       48              
==========================================
- Hits        24696    24691       -5     
  Misses      19106    19106              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test results

       9 files         9 suites   8m 0s ⏱️
3 320 tests 3 320 ✔️ 0 💤 0
6 379 runs  6 379 ✔️ 0 💤 0

Results for commit 4986f48.

Copy link
Contributor

@stveit stveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but should wait for merge until the linting is fixed

Since Python 3.9 one can simply use the build-in version
@johannaengland johannaengland merged commit 6db7049 into Uninett:master Sep 2, 2024
11 of 12 checks passed
@johannaengland johannaengland deleted the remove-imports-from-typing branch September 2, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants