Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test's aren't passing == Bad Install? #47

Closed
gauntface opened this issue Dec 3, 2016 · 2 comments
Closed

Test's aren't passing == Bad Install? #47

gauntface opened this issue Dec 3, 2016 · 2 comments

Comments

@gauntface
Copy link

Again - apologies if this is the wrong place to post this.

I've just tried running all the tests for my lithium install I'm there are a couple of fatal errors and I'm just wondering how much of that is a bad environment vs it's a beta release and tests aren't there yet?

Fatal error: Uncaught Error: Cannot use object of type lithium\storage\session\adapter\Cookie as array in /<Site Directory>/server/libraries/lithium/storage/session/adapter/Cookie.php:163 Stack trace: #0 /<Site Directory>/server/libraries/lithium/tests/cases/storage/session/adapter/CookieTest.php(268): lithium\storage\session\adapter\Cookie->lithium\storage\session\adapter\{closure}(Object(lithium\storage\session\adapter\Cookie), Array, NULL) #1 /<Site Directory>/server/libraries/lithium/tests/cases/storage/session/adapter/CookieTest.php(268): Closure->__invoke(Object(lithium\storage\session\adapter\Cookie), Array, NULL) #2 /<Site Directory>/server/libraries/lithium/test/Unit.php(1613): lithium\tests\cases\storage\session\adapter\CookieTest->testNameWithDotCookie() #3 /<Site Directory>/server/libraries/lithium/aop/Filters.php(231): lithium\test\Unit->lithium\test\{closure}(Array) #4 /<Site Directory>/server/libraries/lithium/test/Unit.php(1617): lithium\aop\Filters::run(Object(lithium\tests\cases\storage\session\adapter\CookieTest), in /<Site Directory>/server/libraries/lithium/storage/session/adapter/Cookie.php on line 163

Problem code is:

$result = $cookie->write($key, $value)->__invoke($cookie, compact('key', 'value'), null);
$this->assertCookie(compact('key', 'value'));
@mariuswilms
Copy link
Member

This seems to be a problem with the tests in UnionOfRAD/lithium:
https://github.com/UnionOfRAD/lithium/blob/1.1/tests/cases/storage/session/adapter/CookieTest.php

It'd be great if reopen this ticket over there. Thanks!

mariuswilms added a commit to UnionOfRAD/lithium that referenced this issue Dec 4, 2016
@mariuswilms
Copy link
Member

Fixed in UnionOfRAD/lithium@938679b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants