Fix for Renderer::_render() with no set $request property. #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Once we get a test case and this is submitted against the dev branch, we'll get it merged in. |
|
Merged to dev in 51d1770 |
|
sorry, got a little busy. I see this had been merged now, do you still need a test case for this? |
|
No, it's fine. @mehlah is actually rewriting the affected code not to rely on |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix in the renderer class for instances when $_request is null. I encountered this when attaching my own error handler method which was not attached to Dispatch::run() as the example error handler is, and thus the request object was not available.
My error template called $this->_render() to include a template element and this raised an ErrorException "Trying to get property of non-object in [...]/Projects/Lithium/dev/li3_core/libraries/lithium/template/view/Renderer.php on line 490";