Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop that occurs when an data\Entity class is used as data\Entity::_model. #782

Merged
merged 1 commit into from
Jan 11, 2013
Merged

Conversation

jails
Copy link
Contributor

@jails jails commented Jan 10, 2013

This may bug occurs when using external ORM which are not based on core data\Model.
I'm not sure for this one because at first glance it looks like data\Entity::_model shouldn't be filled with something which is not a core data\Model subclass.
However if it makes sense, maybe a:

!is_a($model, 'lithium\data\Entity', true)

would here be better than a:

method_exists($model, '_object')

for fixing this issue ?

nateabele added a commit that referenced this pull request Jan 11, 2013
Fix infinite loop that occurs when an `data\Entity` class is used as `data\Entity::_model`.
@nateabele nateabele merged commit 56074bb into UnionOfRAD:dev Jan 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants