Make view step filter pass renderer & template in param instead of use #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've ran into this issue before playing with a templating plugin. 👍 |
|
Yeah, I'm good with the patch in principle. I'm just waiting for the Travis build to fail on the line length. :-) Once this passes the coding standard, I'll merge it. |
|
Done thanks! |
nateabele
added a commit
that referenced
this pull request
Jan 23, 2013
Make view step filter pass renderer & template in param instead of use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to filter any type of view creation or path manipulation is almost impossible currently. You have to over write the adapters directly which is undesirable. Allowing _renderer & _loader inside params gives access to the needed functions inside the filter.