Make view step filter pass renderer & template in param instead of use #796

Merged
merged 1 commit into from Jan 23, 2013

Conversation

Projects
None yet
3 participants
Contributor

brandonwestcott commented Jan 23, 2013

Attempting to filter any type of view creation or path manipulation is almost impossible currently. You have to over write the adapters directly which is undesirable. Allowing _renderer & _loader inside params gives access to the needed functions inside the filter.

Member

blainesch commented Jan 23, 2013

I've ran into this issue before playing with a templating plugin. 👍

Owner

nateabele commented Jan 23, 2013

Yeah, I'm good with the patch in principle. I'm just waiting for the Travis build to fail on the line length. :-) Once this passes the coding standard, I'll merge it.

Contributor

brandonwestcott commented Jan 23, 2013

Done thanks!

nateabele added a commit that referenced this pull request Jan 23, 2013

Merge pull request #796 from brandonwestcott/view_step_filter
Make view step filter pass renderer & template in param instead of use

@nateabele nateabele merged commit eaed604 into UnionOfRAD:dev Jan 23, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment