This adds a media_player_keep_if_same setting to ds::ui::MediaPlayer…
#105
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, allowing you to keep the current resource when loading the same media. This is useful if you have a sequence of templates, each using the same background media. The background media would continue to show uninterrupted.
s133p
reviewed
Mar 19, 2024
| if (mInitialized) uninitialize(); | ||
| if (mInitialized) { | ||
| // If the resource is the same, don't do anything. | ||
| if (mMediaViewerSettings.mKeepIfSame && reccy.getAbsoluteFilePath() == mResource.getAbsoluteFilePath()) return; |
There was a problem hiding this comment.
In addition to checking the path you'll need to confirm if the cropping is the same for images here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…allowing you to keep the current resource when loading the same media.
This is useful if you have a sequence of templates, each using the same background media. The background media would continue to show uninterrupted.