Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide modal upon keyboard blur #7457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Oct 12, 2023

Description

This change mimics the mousedown event of Modals, extending the same functionality to blurring the Modal via tabbing out of the first or last element via the keyboard tab key. With this PR, if you tab off of the first or last item of a given modal, the modal is closed, just clicking outside the Modal would.

Test plan

  1. Click the top bar's "..." item
  2. Continuously press [tab]
  3. When tabbing off the last item, the modal will close
  4. Click the top bar's "..." item
  5. Press shit-tab to bail out of the first item, see the modal close

Visual

Screen.Recording.2023-10-11.at.9.31.21.PM.mov

QA (ie manual testing)

  • N/A

Devices

Automated testing

  • Unit test
  • Integration/E2E test

@darkwing darkwing requested review from a team and zzmp October 12, 2023 02:30
@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 2:32am

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #7457 (08a46a2) into main (5fee3c6) will decrease coverage by 0.10%.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

Flag Coverage Δ
cloud-tests ?
unit-tests 42.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@zzmp zzmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but going to check the UX with design first

@zzmp zzmp requested a review from infredible October 17, 2023 16:55
@infredible
Copy link
Collaborator

lgtm, thanks for the fix!

@darkwing
Copy link
Contributor Author

Bump on cloud tests?

@zzmp zzmp added the reference Reference PR label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reference Reference PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants