fix: Make Swap to / from toggle keyboard accessible #7461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zzmp
reviewed
Oct 17, 2023
| @@ -69,10 +69,13 @@ import { useIsDarkMode } from '../../theme/components/ThemeToggle' | |||
| import { OutputTaxTooltipBody } from './TaxTooltipBody' | |||
| import { UniswapXOptIn } from './UniswapXOptIn' | |||
|
|
|||
| export const ArrowContainer = styled.div` | |||
| export const ArrowContainer = styled.button` | |||
There was a problem hiding this comment.
Rather than change this to a button, which requires additional styles, would it be feasible to render the actual component using as="button" (docs)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At present the down/up-arrow button to switch the "You pay" and "You receive" value is not keyboard accessible. Simply switching to using a
buttonelement, with some helpful CSS, makes this element more accessible.Screen capture
Screen.Recording.2023-10-12.at.9.49.31.PM.mov
QA (ie manual testing)
Devices
Automated testing