Revert "fix: manually filter out fantom cached routes (#712)" #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3f68d2e.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (05/25/24)5 reviewers were added and 1 assignee was added to this PR based on 's automation. |
cgkol
approved these changes
May 25, 2024
xumoyan
pushed a commit
to xumoyan/routing-api
that referenced
this pull request
Aug 20, 2024
* 'main' of github.com:xumoyan/routing-api: (155 commits) fix: bump lambda version to pick up new zksync secret (Uniswap#730) feat: support routing on zksync (Uniswap#729) feat: double sampling tenderly node estimate gas api (Uniswap#728) chore: remove quicknodetest_1 sampling (Uniswap#727) feat: shadow tenderly new node endpoint (Uniswap#726) fix: add quicknodetest_1 into the secret fetch list (Uniswap#725) fix: bump lambda version to pick up secrets in env var (Uniswap#724) fix: quicknode test key naming (Uniswap#723) chore: shadow sampling mainnet traffic to quicknode test key (Uniswap#722) chore(subgraph-cache): Increase retries on decentralized network endpoints (Uniswap#721) chore: remove nirvana from sampling and 5x alchemy sampling traffic (Uniswap#720) chore(subgraph): Use decentralized network arbitrum subgraph (Uniswap#719) chore: increase alchemy shadow sampling by 10x (Uniswap#718) fix(cache job): Switch to the uniswap-v2-dev subgraph (Uniswap#717) fix(caching): Try older version of subgraph (Uniswap#716) fix(caching): Use decentralized network v2 subgraph on Mainnet (Uniswap#715) chore(cron): Migrate Polygon to Alchemy (Uniswap#714) Revert "fix: manually filter out fantom cached routes (Uniswap#712)" (Uniswap#713) fix: manually filter out fantom cached routes (Uniswap#712) fix: bump lambda version to pick up the new s3 subgraph pool files (Uniswap#711) ... # Conflicts: # bin/app.ts # bin/stacks/routing-api-stack.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3f68d2e.
This is an arbitrary fix, that is short-term. Also I figured out a way to delete the cached routes entry in dynamo DB, so in future, we shouldn't need to apply this kind of hack, if we need to make sure certain cached routes don't get returned.