fix: hardcode gas on celo #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (06/25/24)6 reviewers were added and 1 assignee was added to this PR based on 's automation. |
cgkol
reviewed
Jun 25, 2024
yes, and also requested by mobile team |
|
@cgkol added unit test |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the gas used proprietary SOR algorithm is too low on celo, but tenderly cannot simulate on celo yet to support accurate gas estimate. mobile launch on celo requires a gas used, that will not result in mass onchain swap failure. We determined that routing-api returns a hardcoded 5 million gas used on celo would avoid large onchain swap failures on mobile.
tested locally with uniswap-web source, gas estimate doesn't change: https://app.warp.dev/block/iYh1m8qV3oW917Xa0W9knf
tested locally with uniswap-ios source, gas estimate changed to 5000000: https://app.warp.dev/block/Tjl6BiNxcK1vkr1yDfhARc