Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Add Rootstock chainId #78

Closed
wants to merge 1 commit into from

Conversation

ahsan-javaiid
Copy link
Contributor

Description

This PR adds Rootstock chain id to this core sdk as integration proposal for Rootstock with Uniswap is under review.

Reason

To continue with rootstock integration in other Uniswap repos the chainId needs to be supported by sdk-core.

Any Questions

Feel free to ask any questions regarding the consideration of this pull request.

@ahsan-javaiid
Copy link
Contributor Author

cc: @alepc253

@stale
Copy link

stale bot commented Oct 2, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Oct 2, 2023
@alepc253
Copy link

alepc253 commented Oct 2, 2023

Yes, this is still relevant

@stale stale bot removed the wontfix This will not be worked on label Oct 2, 2023
Copy link

stale bot commented Dec 15, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Dec 15, 2023
@alepc253
Copy link

Yes, it is (and it should be quite easy to review and merge).

@stale stale bot removed the wontfix This will not be worked on label Dec 15, 2023
Copy link

stale bot commented Feb 13, 2024

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Feb 13, 2024
@alepc253
Copy link

Yes, still waiting for review and merge

@stale stale bot closed this Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants