Failing test for AlphaRouter.calculateOptimalRatio()

[eliotstock]

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Failing test

• What is the current behavior? (You can also link to an open issue here)

The ratio returned by AlphaRouter.calculateOptimalRatio() is out by about 2% for this test case.

• What is the new behavior (if this is a feature change)?

• Other information:

[ewilz]

can look into this. It's possible that the fraction is taking into account Price Impact. If you need to trade through the pool you're providing liquidity to, you will move the price, and hence affect the ratio. (edit: nvm, not it, since you're calling the pure function)

[eliotstock]

Thanks for taking a look. I would expect only a tiny price impact for this size of swap in a real pool, but I don't know how the tests handle liquidity in the pool. Isn't the implementation of calculateOptimalRatio() completely independent of liquidity in the pool?

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.