Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow-less summary storage #222

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Conversation

Lipen
Copy link
Collaborator

@Lipen Lipen commented Feb 29, 2024

This PR proposes to add a summary storage without Flow's, which allows for deterministic (non-asynchronous!) subscriptions on summary edges.
Ultimately, this enables us to use MethodUnitResolver without any doubts, which currently is not very possible to due the fact that method-bound runners might die (i.e. might be killed by the manager) due to their queue exhaustion before the subscription on summary edges will be handled by the separate spawned coroutine (launch + SharedFlow::collect).

TODO:

  • consider renaming the existing summary storage impl
  • refine the interface of the summary storage
  • add tests utilizing the MethodUnitResolver

Copy link
Contributor

github-actions bot commented Feb 29, 2024

Test results on JDK 8

1 325 tests  ±0   1 311 ✅ ±0   4m 35s ⏱️ -29s
   48 suites ±0      14 💤 ±0 
   48 files   ±0       0 ❌ ±0 

Results for commit f562c7b. ± Comparison against base commit bf3f6b4.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 34.95146% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 75.52%. Comparing base (bf3f6b4) to head (f562c7b).
Report is 1 commits behind head on develop.

Files Patch % Lines
...c/main/kotlin/org/jacodb/analysis/ifds/Producer.kt 14.86% 63 Missing ⚠️
...rc/main/kotlin/org/jacodb/analysis/ifds/Summary.kt 83.33% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #222      +/-   ##
=============================================
- Coverage      75.78%   75.52%   -0.27%     
- Complexity      1649     1653       +4     
=============================================
  Files            175      176       +1     
  Lines          10241    10421     +180     
  Branches        1892     1937      +45     
=============================================
+ Hits            7761     7870     +109     
- Misses          1715     1787      +72     
+ Partials         765      764       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 29, 2024

Test results on JDK 19

1 325 tests  ±0   1 313 ✅ ±0   7m 32s ⏱️ + 2m 30s
   48 suites ±0      12 💤 ±0 
   48 files   ±0       0 ❌ ±0 

Results for commit f562c7b. ± Comparison against base commit bf3f6b4.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 29, 2024

Test results on JDK 11

1 325 tests  ±0   1 315 ✅ ±0   7m 18s ⏱️ +59s
   48 suites ±0      10 💤 ±0 
   48 files   ±0       0 ❌ ±0 

Results for commit f562c7b. ± Comparison against base commit bf3f6b4.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 29, 2024

Lifecycle test results

48 tests  ±0   48 ✅ ±0   1m 24s ⏱️ -1s
 5 suites ±0    0 💤 ±0 
 5 files   ±0    0 ❌ ±0 

Results for commit f562c7b. ± Comparison against base commit bf3f6b4.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant