Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Persistence API #230

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Rework Persistence API #230

merged 4 commits into from
Jun 20, 2024

Conversation

Saloed
Copy link
Collaborator

@Saloed Saloed commented Jun 17, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Jun 17, 2024

Lifecycle test results

49 tests  +1   49 ✅ +1   1m 44s ⏱️ +20s
 6 suites +1    0 💤 ±0 
 6 files   +1    0 ❌ ±0 

Results for commit 8771de5. ± Comparison against base commit 5102242.

♻️ This comment has been updated with latest results.

@Saloed Saloed force-pushed the saloed/persistence-rework branch from c75ba3b to 78b9bab Compare June 17, 2024 17:29
Copy link
Contributor

github-actions bot commented Jun 17, 2024

Test results on JDK 19

   80 files  +   23     80 suites  +23   21m 45s ⏱️ + 9m 59s
2 573 tests +1 216  2 546 ✅ +1 206  27 💤 +10  0 ❌ ±0 
2 601 runs  +1 244  2 574 ✅ +1 234  27 💤 +10  0 ❌ ±0 

Results for commit 8771de5. ± Comparison against base commit 5102242.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 17, 2024

Test results on JDK 11

   80 files  +   23     80 suites  +23   24m 24s ⏱️ + 10m 38s
2 573 tests +1 216  2 548 ✅ +1 206  25 💤 +10  0 ❌ ±0 
2 601 runs  +1 244  2 576 ✅ +1 234  25 💤 +10  0 ❌ ±0 

Results for commit 8771de5. ± Comparison against base commit 5102242.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 79.50089% with 805 lines in your changes missing coverage. Please review.

Project coverage is 67.27%. Comparing base (5102242) to head (8771de5).

Files Patch % Lines
...pl/storage/ers/ram/XodusPersistentCollectionsEx.kt 2.53% 77 Missing ⚠️
...jacodb/impl/storage/PersistentLocationsRegistry.kt 66.82% 65 Missing and 5 partials ⚠️
.../kotlin/org/jacodb/impl/JCDBSymbolsInternerImpl.kt 57.31% 32 Missing and 3 partials ⚠️
...in/kotlin/org/jacodb/impl/storage/JcRefactoring.kt 2.77% 35 Missing ⚠️
.../org/jacodb/impl/storage/kv/rocks/RocksNamedMap.kt 60.71% 26 Missing and 7 partials ⚠️
...org/jacodb/impl/storage/AbstractJcDbPersistence.kt 53.73% 24 Missing and 7 partials ⚠️
...mpl/storage/ers/jooq/tables/records/TypesRecord.kt 0.00% 25 Missing ⚠️
...org/jacodb/impl/storage/ers/kv/KVErsTransaction.kt 78.26% 14 Missing and 11 partials ⚠️
...codb/impl/storage/kv/rocks/RocksKeyValueStorage.kt 69.87% 20 Missing and 5 partials ⚠️
...c/main/kotlin/org/jacodb/impl/features/Builders.kt 78.21% 20 Missing and 2 partials ⚠️
... and 70 more
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #230      +/-   ##
============================================
+ Coverage     65.18%   67.27%   +2.09%     
- Complexity     2035     2580     +545     
============================================
  Files           223      294      +71     
  Lines         15564    18438    +2874     
  Branches       2908     3296     +388     
============================================
+ Hits          10146    12405    +2259     
- Misses         4382     4827     +445     
- Partials       1036     1206     +170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Test results on JDK 8

   80 files  +   23     80 suites  +23   27m 6s ⏱️ + 12m 51s
2 573 tests +1 216  2 543 ✅ +1 205  30 💤 +11  0 ❌ ±0 
2 601 runs  +1 244  2 571 ✅ +1 233  30 💤 +11  0 ❌ ±0 

Results for commit 8771de5. ± Comparison against base commit 5102242.

@Saloed Saloed requested a review from CaelmBleidd June 17, 2024 19:25
@Saloed Saloed merged commit c141db7 into neo Jun 20, 2024
11 checks passed
@Saloed Saloed deleted the saloed/persistence-rework branch June 20, 2024 14:40
CaelmBleidd pushed a commit that referenced this pull request Jul 5, 2024
* Rework Persistence API

(cherry picked from commit c141db7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants