Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instances option allows non number value, starts infinite instances #1091

Closed
thoreinstein opened this issue Mar 13, 2015 · 1 comment · Fixed by #1102
Closed

Instances option allows non number value, starts infinite instances #1091

thoreinstein opened this issue Mar 13, 2015 · 1 comment · Fixed by #1102

Comments

@thoreinstein
Copy link

pm2 --version: 0.12.7
iojs --version: 1.5.1
os: Ubuntu 12.04.4 LTS (GNU/Linux 3.11.0-15-generic x86_64)
os: OS X 10.9.4

Launching an application with pm2 start index.js --name "test" -i 0 performs as expected and launches one instance per core of my machine.
screen shot 2015-03-13 at 3 16 41 pm

However one missed keystroke pm2 start index.js --name "test" -i o continues to launch instances of the application until kernel panic.

screen shot 2015-03-13 at 3 20 17 pm
screen shot 2015-03-13 at 3 20 43 pm

I attempted to run this with debugging on, however calling start with -i o seems to just hang the process and does not log anything to stdout or stderr. This is can be reproduced on both my local MacBook Pro and my server.

I will do my best to try to work on this issue. Unfortunately I cannot do anything until I am off of corporate resources.

@jorge-d
Copy link
Contributor

jorge-d commented Mar 16, 2015

Thank you for reporting this, I confirm the fork bomb on my Macbook as well :]

Investigating this right now,

jshkurti added a commit that referenced this issue Mar 16, 2015
Improve instance option parsing to avoid fork bomb, fix #1091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants