Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump backup #3001

Merged
merged 4 commits into from Aug 29, 2017
Merged

Dump backup #3001

merged 4 commits into from Aug 29, 2017

Conversation

bisubus
Copy link
Contributor

@bisubus bisubus commented Jul 5, 2017

Backs up a dump, in case of an exception during dump save.

Renames dump.pm2 to dump.pm2.bak before writing it. Falls back to dump backup on resurrection. Removes a dump if it's broken to avoid unwanted backup overwrite.

Because the only time when we want to lose saved processes is... on second thought, no, we never want to lose them 馃槹

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2971, #2827
License MIT

@vmarchaud vmarchaud requested a review from Unitech July 5, 2017 22:30
@Unitech Unitech added the PM2 v3 label Jul 20, 2017
@Unitech
Copy link
Owner

Unitech commented Aug 29, 2017

@bisubus nice job, could you sign the CLA https://cla-assistant.io/Unitech/pm2?pullRequest=3001 so we can merge the PR. Thank you

@bisubus
Copy link
Contributor Author

bisubus commented Aug 29, 2017

@Unitech Sure.

@Unitech Unitech merged commit de0f88e into Unitech:development Aug 29, 2017
@Unitech
Copy link
Owner

Unitech commented Aug 29, 2017

Awesome thank you

inerc pushed a commit to inerc/pm2 that referenced this pull request Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants