Fix memory leak warnings; Fix existing LOD group warning

Unity-Technologies · Aug 30, 2019 · cdc00f8 · cdc00f8
1 parent d5513b7
commit cdc00f8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Scripts/Editor/ModelImporterLODGenerator.cs b/Scripts/Editor/ModelImporterLODGenerator.cs
@@ -185,7 +185,7 @@ void OnPostprocessModel(GameObject go)
                             AssetDatabase.SaveAssets();
 
                         // Process dependencies first
-                        var jobDependencies = new NativeArray<JobHandle>(preprocessMeshes.Count, Allocator.Temp);
+                        var jobDependencies = new NativeArray<JobHandle>(preprocessMeshes.Count, Allocator.Persistent);
                         var i = 0;
                         meshLODs.RemoveAll(ml =>
                         {
@@ -272,7 +272,7 @@ void OnPostprocessModel(GameObject go)
                     lods.Add(lod);
                 }
 
-                if (importerLODLevels.arraySize != 0 && maxLODFound != importerLODLevels.arraySize)
+                if (importerLODLevels.arraySize != 0 && maxLODFound != importerLODLevels.arraySize - 1)
                     Debug.LogWarning("The model has an existing lod group, but it's settings will not be used because " +
                         "the specified lod count in the AutoLOD settings is different.");
 

diff --git a/Scripts/Helpers/MeshLOD.cs b/Scripts/Helpers/MeshLOD.cs
@@ -60,10 +60,10 @@ public JobHandle Generate(NativeArray<JobHandle>? jobDependencies = null)
             MonoBehaviourHelper.ExecuteOnMainThread(() => { });
 
             var job = new GenerateMeshLODJob();
-            job.inputMesh = inputMesh.ToWorkingMesh(Allocator.TempJob);
+            job.inputMesh = inputMesh.ToWorkingMesh(Allocator.Persistent);
             job.quality = quality;
             var typeNameBytes = Encoding.UTF8.GetBytes(meshSimplifierType.AssemblyQualifiedName);
-            job.meshSimplifierTypeName = new NativeArray<byte>(typeNameBytes, Allocator.TempJob);
+            job.meshSimplifierTypeName = new NativeArray<byte>(typeNameBytes, Allocator.Persistent);
             job.outputMesh = new WorkingMesh(Allocator.Persistent, inputMesh.vertexCount, inputMesh.GetTriangleCount(),
                 inputMesh.subMeshCount, inputMesh.blendShapeCount);