Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition on Android and make it a package #11

Merged
merged 13 commits into from
Nov 29, 2019
Merged

Fix race condition on Android and make it a package #11

merged 13 commits into from
Nov 29, 2019

Conversation

aurimasc
Copy link
Collaborator

@aurimasc aurimasc commented Nov 22, 2019 •
edited
Loading

Should fix issue: #9
Make background a package.

MantsSk
MantsSk approved these changes Nov 29, 2019
View reviewed changes
Copy link

@MantsSk MantsSk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a smoke test on iOS/Android platforms. Package is looking good, downloads complete successfully, their progress and status are shown accordingly.

I couldn't verify the fix though, as I wasn't able to reproduce the issue in a first place.

@aurimasc aurimasc merged commit de98fe8 into master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Over17 Over17 Over17 approved these changes

@MantsSk MantsSk MantsSk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aurimasc @Over17 @MantsSk