Vfx/fix/context no blocks (#27)

Unity-Technologies · Jul 21, 2020 · f4e38ea · f4e38ea
1 parent 67ca602
commit f4e38ea
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/com.unity.visualeffectgraph/CHANGELOG.md b/com.unity.visualeffectgraph/CHANGELOG.md
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ## [Unreleased]
 ### Fixed
 - Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.
+- Don't show the blocks window when context cant have blocks
 
 ## [7.5.0] - 2020-06-08
 

diff --git a/com.unity.visualeffectgraph/Editor/GraphView/Elements/VFXContextUI.cs b/com.unity.visualeffectgraph/Editor/GraphView/Elements/VFXContextUI.cs
@@ -46,6 +46,8 @@ protected override void OnNewController()
             m_CanHaveBlocks = blocks.Any(t => controller.model.AcceptChild(t.model));
         }
 
+        public bool canHaveBlocks { get => m_CanHaveBlocks; }
+
         public static string ContextEnumToClassName(string name)
         {
             if (name[0] == 'k')

diff --git a/com.unity.visualeffectgraph/Editor/GraphView/Views/VFXView.cs b/com.unity.visualeffectgraph/Editor/GraphView/Views/VFXView.cs
@@ -1102,7 +1102,8 @@ void OnCreateNode(NodeCreationContext ctx)
 
             if (context != null)
             {
-                context.OnCreateBlock(point);
+                if(context.canHaveBlocks)
+                    context.OnCreateBlock(point);
             }
             else
             {