Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue where world space UI was not emitted for reflection cameras in HDRP [Depends on C++] #1098

Merged
merged 5 commits into from Aug 25, 2020
Merged

Fix an issue where world space UI was not emitted for reflection cameras in HDRP [Depends on C++] #1098

merged 5 commits into from Aug 25, 2020

Conversation

JulienIgnace-Unity
Copy link
Collaborator

Purpose of this PR

Fix an issue where world space UI was not emitted for reflection cameras in HDRP.
This fixes this issue: https://fogbugz.unity3d.com/f/cases/1155022
It needs this Ono PR to work: https://ono.unity3d.com/unity/unity/pull-request/108914/_/graphics/fix-srp-worldui

Testing status

Manual Tests: What did you do?
Tested the provided scene with the fix and it worked fine.

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)

@JulienIgnace-Unity
Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…
925de11 
…Graphics into HDRP/fix-world-ui

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md
RemyUnity
RemyUnity approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@RemyUnity RemyUnity left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forget this comment

@RemyUnity RemyUnity self-requested a review July 3, 2020 12:03
@sebastienlagarde
Copy link
Collaborator

@RemyUnity : Be sure to chek in editor, Playmode and Player. Last time we get this issue the behavior in player was different

@sebastienlagarde sebastienlagarde changed the title Fix an issue where world space UI was not emitted for reflection cameras in HDRP Fix an issue where world space UI was not emitted for reflection cameras in HDRP [Depends on C++] Jul 3, 2020
RemyUnity
RemyUnity approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@RemyUnity RemyUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check in editor/playmode/runtime, fix confirmed.

@JulienIgnace-Unity
Merge branch 'HDRP/staging' of https://github.com/Unity-Technologies/…
8c4ed5c 
…Graphics into HDRP/fix-world-ui

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md
@JulienIgnace-Unity
Added proper ifdef for 2020.2
9052326
@JulienIgnace-Unity JulienIgnace-Unity merged commit 6dc41e0 into HDRP/staging Aug 25, 2020
@JulienIgnace-Unity JulienIgnace-Unity deleted the HDRP/fix-world-ui branch August 25, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde left review comments

@pmavridis pmavridis pmavridis approved these changes

@RemyUnity RemyUnity RemyUnity approved these changes

Assignees
No one assigned
Labels
HDRP
Projects
None yet
Milestone
No milestone
4 participants
@JulienIgnace-Unity @sebastienlagarde @pmavridis @RemyUnity