Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HDRP][Compositor] Fixed assertion failure when switching resolution and AOV settings #1489

Merged
merged 2 commits into from Aug 6, 2020
Merged

[HDRP][Compositor] Fixed assertion failure when switching resolution and AOV settings #1489

merged 2 commits into from Aug 6, 2020

Conversation

pmavridis
Copy link
Contributor

@pmavridis pmavridis commented Aug 3, 2020 •
edited

Purpose of this PR

https://fogbugz.unity3d.com/f/cases/1265023/
https://fogbugz.unity3d.com/f/cases/1268148/

The original code was trying to release an RTHandle by passing it directly to CoreUtils.Destroy and this is not the correct way to release RTHandles...

Testing status

  • The assertion does not fail anymore after performing the repro steps for 1265023 on a fresh HDRP template.
  • The assertion does not fail anymore after performing the repro steps for 1268148 on a fresh HDRP template.
  • I have also tested a more complex compositor setup and switching AOVs and resolutions does not repro the issue anymore.

@pmavridis pmavridis added the HDRP label Aug 3, 2020
@pmavridis pmavridis requested review from sebastienlagarde and a team August 3, 2020 19:20
TomasKiniulis
TomasKiniulis approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@TomasKiniulis TomasKiniulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not getting the issue on both cases adjusting AOVs, resolution, enabling/disabling compositor

@sebastienlagarde sebastienlagarde marked this pull request as ready for review August 6, 2020 08:19
@sebastienlagarde sebastienlagarde merged commit df6a489 into HDRP/staging Aug 6, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/case_1265023 branch August 6, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@TomasKiniulis TomasKiniulis TomasKiniulis approved these changes

Assignees
No one assigned
Labels
HDRP
Projects
None yet
Milestone
No milestone
3 participants
@pmavridis @sebastienlagarde @TomasKiniulis